blish-hud/Blish-HUD

Label.ShadowColor does not affect Label.StrokeText

Taschenbuch opened this issue · 1 comments

Taschenbuch commented

observed behavior:

Stroke color seems to be always Black even when Label.ShadowColor is set to Color.White.

expected behavior:

  • changing stroke color with Label.ShadowColor should be used as Stoke color (or even better: add something like Label.StrokeColor)
  • OR: update Description of StokeText and ShadowColor that they are not related.

Note from freesnow

I think technically the description on the property is just wrong. There doesn't appear to have ever been an attempt to actually have ShadowColor impact the stroke color.

Blish-HUD/Blish HUD/_Extensions/SpriteBatchExtensions.cs

Line 196 in 651dee4

var strokePreMultiplied = Color.Black * absoluteOpacity;

Examples:

with strokeText

new Label
{
    Text           = text,
    TextColor = Color.Black,
    StrokeText = true,
    ShadowColor = Color.White,
    AutoSizeHeight = true,
    AutoSizeWidth  = true,
    Parent         = parent
};

image

image

same without strokeText

new Label
{
    Text           = text,
    TextColor = Color.Black,
    AutoSizeHeight = true,
    AutoSizeWidth  = true,
    Parent         = parent
};

image

relevant discord chat

https://discord.com/channels/531175899588984842/536970543736291346/1213597398635520050

dlamkins commented

Note to self: Probably best to update the description and consider making a new property for the stroke color. Granted, they (stroke + shadow) should be mutually exclusive, so a shared property makes sense, but it is confusing. 🤔