info.blockchain.api.blockexplorer.LatestBlock.java
ecerchia opened this issue · 0 comments
ecerchia commented
- Ideally every class should live where it belongs. Since this is used as a data transfer object I would create a new package and move it there [info.blockchain.api.dto.LatestBlock.java]. Need to consider if this breaks any clients though (internal + external).
- Var rename https://github.com/blockchain/api-v1-client-java/blob/master/src/main/java/info/blockchain/api/blockexplorer/LatestBlock.java#L22
- Potential for NUPEs if we are passed nulls https://github.com/blockchain/api-v1-client-java/blob/master/src/main/java/info/blockchain/api/blockexplorer/LatestBlock.java#L68