blockfrost/blockfrost-go

Support passing a custom *http.Client

Closed this issue · 4 comments

jybp commented

AFAICT there is no way to currently pass a custom *http.Client to the lib. Meaning consumers have no way to configure it nor can they use custom http.RoundTrippers.
It's usually a good practice to allow that. An example of another api wrapper: https://github.com/google/go-github/blob/master/github/github.go#L312-L321

IDK if maintainers have bandwidth for this feature but I can work toward a PR if that's OK.

slowbackspace commented

Hi @jybp, if you could find the time to implement this, PR would be highly appreciated. We don't really have the capacity for diving too deep into go right now.

  • 👍1
slowbackspace commented

Hi @jybp, just want to let you know that 0.2.0 is out now!

https://github.com/blockfrost/blockfrost-go/releases/tag/v0.2.0

  • 🎉1
jybp commented

Great! Thanks for the notification!