blocknative/notify

TransactionEventCode is outdated

Closed this issue · 1 comments

The TransactionEventCode seems to have outdated keys:

notify/src/interfaces.ts

Lines 25 to 40 in f8f5180

export type TransactionEventCode =
| 'txSent'
| 'txPool'
| 'txConfirmed'
| 'txSpeedUp'
| 'txCancel'
| 'txFailed'
| 'txRequest'
| 'nsfFail'
| 'txRepeat'
| 'txAwaitingApproval'
| 'txConfirmReminder'
| 'txSendFail'
| 'txError'
| 'txUnderPriced'
| 'all'

From what I can see those are the working event keys: https://docs.blocknative.com/notify-sdk#event-codes. And those ones are outdated: https://docs.blocknative.com/notify#event-codes.

It would be great if the TransactionEventCode could reflect the working event codes. And it also would be great to know if those event codes: https://docs.blocknative.com/notify#event-code will be supported in the future.

Hey @gorgos, thanks for pointing this out. The difference that you see between the event codes listed in the SDK documentation vs the event codes that are listed in the Notify.js docs are the extra "pre-flight" events that Notify will create client side when using the transaction function. I have updated the Notify docs to make this more clear: https://docs.blocknative.com/notify#event-codes