bloomberg/goldpinger

Windows Container support

dorbeus opened this issue · 14 comments

dorbeus commented

Is your feature request related to a problem? Please describe.
I'm testing running Kubernetes with Windows nodes, so of course i need this tool, but there is no instruction of how to build and run this in a Windows container.

Describe the solution you'd like
A instruction of how to build this on a windows container and preferably a pre-build container on docker-hub
A instruction of how to deploy this on a mixed Linux/Windows Kubernetes cluster.

Describe alternatives you've considered
Building this myself, but then i need to understand how go things are build.

Additional context

seeker89 commented

It's a good point. I have no experience with Windows Containers, but I'd be happy to assist anyone who'd like to give it a shot.

rbtr commented

@seeker89 I'm willing to pick this feature up (because I would like to use it, ofc), but I will warn you up front that making multiplat images for Windows is a bit ugly 🙂

seeker89 commented

That would be awesome!

jkroepke commented

I found some windows images on DockerHub (careful: random user), no github project linked: https://hub.docker.com/r/tylloyd/goldpinger

rbtr commented

@jkroepke that's @tyler-lloyd who was investigating implementing this. those are very unofficial dev/test images but are probably functional

  • 👍1
tyler-lloyd commented

@jkroepke, @rbtr is right. very unofficial. here is the script I am working with right now. still figuring out how to contribute back to this project. currently running into issues with more recent verions of buildkit. tyler-lloyd@5214711

jkroepke commented

@tyler-lloyd please let me know if I can assists here. I need them soon and I would not like to copy and own docker images.

I hope @seeker89 and @skamboj are still open for the kind of feature.

jkroepke commented

Again, can I help here?

tyler-lloyd commented

@jkroepke - taking a look at your PR! thanks for picking this up!

jkroepke commented

@tyler-lloyd I found the blog artical which mention the cross OS builds for Windows. But instead using the shell scripts, I modernize the concept by using buildx bake

tyler-lloyd commented

I saw. The bake stuff is new to me so I'm interested to learn more about it. Do you have a test repository we can pull from that used your new ci tooling?

jkroepke commented

Whoops. Omit the v prefix on docker tags is very common. It's also the default behavior on the metadata-action. Sorry for this. I do not looked deeper on existing version.

In case the v prefix should be ensured, replace

goldpinger/.github/workflows/main.yml

Line 59 in 0b96e45

type=semver,pattern={{version}}

with

             type=semver,pattern={{raw}}

Should add the v again