Stream filter should be optional even if the user doesn’t have full permissions
vfaronov opened this issue · 1 comments
Hi, thanks for building and maintaining this tool.
I run Bonfire on a Graylog instance where I don’t have full permissions. This causes it to prompt me for a stream to query. But regardless of which stream I select (including “All messages”), I get no results. However, if I remove this check from the code, it doesn’t pass the filter
parameter to Graylog, and then I do get the expected results.
I could make a fix for this, but I don’t know enough about Graylog to decide on the proper course of action:
- Is it wrong for Bonfire to assume “absent
[*]
permissions, a stream must be selected”? Should it always default to “no stream filter” and only prompt if e.g.--stream prompt
is specified? - Should Bonfire provide an explicit “force disable stream filter” option, e.g.
--stream all
and a corresponding option in the prompt? - Should I just use the “All messages” stream? Is it wrong/unusual that Bonfire gives no results from it? I do get the results when I query this stream in the Graylog UI. (But I don’t control this instance, and if it’s somehow misconfigured, it’s unlikely to change.)
thanks for reporting this bug / unexpected behaviour! i'm sadly sorely pressed for time, and the other issue has been waiting for weeks now, but i'm gonna try to look into this. optimistically this week, more realisticaly it'll take a few weeks. I shall try to prioritize bonfire!