blue-yonder/urlquote

Release version 2.0

Closed this issue · 23 comments

Updated the bulid sytem to maturin to keep up with the times (and newer Python Versions). Also switched from travis to GitHub actions. If somebody with appropriate rights would please add a PYPI_API_TOKEN secret to the repository and create a (GitHub) release. I no longer work at BY and do not have the rights to do so.

Cheers, Markus

@pacman82 I did trigger the 2.0.0 release but the auth for pypi fails and I did read this too late 🤦 and thought the trigger of the release is the issues. There I lack the power to resolve this, have to check who can fix the credentials.

@bjoernmeier I do not mind bias to action, and nothing bad happend. Personally I would just delete the release and the tag. It is not like anything has been published. We can also just release 3.0 next time.

I already cleaned up. Probably was still too early :D and I thought only the release was required and missed that the Token is the issue. Will see what I can do there.

can the exact error message still be seen somewhere?

this one, right?

ERROR    HTTPError: 403 Forbidden from https://upload.pypi.org/legacy/          
         Invalid or non-existent authentication information. See                
         https://pypi.org/help/#invalid-auth for more information.              
Error: Process completed with exit code 1.

Sure, the action history is still there https://github.com/blue-yonder/urlquote/actions/runs/3407964540/jobs/5668102955#step:4:235.

Some note: waybe at some place we should change the name of one of the 2 github workflows so that the tests and package build/upload do not have the same name.

@sebastianneubauer The authentication error is no mystery. We need a configured secret by the name of PYPI_API_TOKEN which is a valid token to push a repository for this PyPI User: https://pypi.org/user/BYPyPi/

Since this is also the user which publishes turbodbc or kartothek somebody at BY is likely to have the credentials for this user. urlquote has previously been deployed using travis. The GitHub Action for deployment never ran before, it is brand new and I just created it in the hope somebody can configure the secret for it.

@sebastianneubauer Any chance you know how to get the PYPY_API_TOKEN secret?

Added a secret with an API token for urlquote in pypi...what do I have to do now?

Added a secret with an API token for urlquote in pypi...what do I have to do now?

As you can see here:

twine upload --skip-existing -u __token__ -p "${{ secrets.PYPI_API_TOKEN }}" dist/*

The CI uses a Github Actions secret named PYPY_API_TOKEN to push to pypi. So we need to add the secret to github actions for this repo and then trigger another build

mmh, failed again:

WARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 403 Forbidden from https://upload.pypi.org/legacy/          
         Invalid or non-existent authentication information. See                
         https://pypi.org/help/#invalid-auth for more information. 

mmh, failed again:

WARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 403 Forbidden from https://upload.pypi.org/legacy/          
         Invalid or non-existent authentication information. See                
         https://pypi.org/help/#invalid-auth for more information. 

@pacman82 @bjoernmeier any idea?

ah, copied it from your comment @yogevyuval , but PYPY_API_TOKEN looks like a typo...

wohoo, seems we have a 2.0 release https://pypi.org/project/urlquote/

ah, copied it from your comment @yogevyuval , but PYPY_API_TOKEN looks like a typo...

Ahhh so sorry! Thanks for the effort!

Looks like for some reason the wheel is still not grabbed by pip on python 3.11
image

strange, worked for me on mac...
Screenshot at Nov 09 22-16-33

strange, worked for me on mac... Screenshot at Nov 09 22-16-33

Doesnt work on python linux docker for some reason
image

mmh, worked for me in docker as well
docker run -ti python:3.11.0 bash
Screenshot at Nov 09 22-23-54

docker run -ti python:3.11.0 bash

Tried it on another linux server and it worked.
I think the problem is that I have an M1 mac. Do the new wheels support M1 / linux docker running on M1?

Hello @yogevyuval ,

name is as intended. As you suggested the ManyLinux wheels deployed on PyPI do not work on ARM architectures like M1. To create one we would need a CI runner with OS-X and ARM. AFAIK GitHub does not offer such a build server.

Luckily urlquote is easy to build. You only need to go to rustup.rs and install the Rust toolchain as proposed by the error message. Then try again to pip install urlquote.

Cheers, Markus

wohoo, seems we have a 2.0 release https://pypi.org/project/urlquote/

Thanks you Sebastian!