ImageView->setImage() throws a compile time error

[peterchappy]

It seems like setImage() throws a compile time error due to it being inline, however once you remove the inline keyword it runs fine. Any idea why @benjaminbojko ?

[benjaminbojko]

Oh good catch; Looks like we haven't been using that method in a while. Three Four options:

1. You could add the inline keyword to the .cpp implementation:
   inline void ImageView::setImage(const gl::TextureRef texture) { setTexture(texture); }
2. You could move the one-line implementation into the .h file and then the compiler should automatically inline it in most cases
3. Remove the inline keyword
4. Remove the setImage() method entirely; It's essentially just calling setTexture() and I believe is sort of a relic. Ultimately I'd love to pick one or the other.

Any thoughts?

[peterchappy]

I'd be okay with getting rid of setImage() and using setTexture() instead. But I feel like @Swiley should weigh in too

[Swiley]

They look to be the same to be, do it @peterchappy!

[benjaminbojko]

@peterchappy Have you had a chance to take a look at this one?

[peterchappy]

Nope sorry last week was a blur, I'll look at this towards the end of the day today.

[benjaminbojko]

Awesome thanks! Didn't mean to rush, was just doing some Spring cleaning with the issues.

[benjaminbojko]

Closed by #65