Request for review of gh/serial
Closed this issue · 2 comments
GoogleCodeExporter commented
Purpose of code changes on this branch:
Introducing a way to access the Arduino serial interfaces.
When reviewing my code changes, please focus on:
There are several things that should be carefully checked:
* As we have had all sort of different problems getting this going, please
verify the functionality. It works here with Arduino 1.0.
* There are API differences between Arduino 0.x and 1.0. This is a potential
source of our problems, if this is the case should we pursuit compatibility
with both?
* Should we have separate ros messages for the different serial interfaces, or
should they be combined to minimize the different messages?
* Currently the configuration is done with the set_poark_config message. To
fit the baud setting, it was split. Is this acceptable, or is it better to
adapt the message or introduce a new message?
After the review, I'll merge this branch into:
master
Original issue reported on code.google.com by hendeby@gmail.com
on 16 Jan 2012 at 10:54
GoogleCodeExporter commented
Thanks for the review of the version one of the CL.
I have pushed an updated version that should address all the issues raised.
Please have a look at the new commit at gh/serial-2.
Original comment by hendeby@gmail.com
on 19 Jan 2012 at 9:14
GoogleCodeExporter commented
Original comment by hendeby@gmail.com
on 22 Jan 2012 at 2:34
- Changed state: Fixed