Enhancement: rewrite of epee library (partial, at least)
Opened this issue · 2 comments
Not liking the things in that library. Historically, its been a source of a fairly large problem at least once (Cisco Talos). Comments in code don't seem to be happy with it either... which draws similar attention to p2p.
- IP addressess handled irresponsibly...
- Removed a gif-content-type from the
http_base.h
header file - For some reason we have code that handles all kinds of media/web files (?)
-blur/contrib/epee/include/net/http_protocol_handler.inl
Lines 663 to 688 in 8fa4725
Consider partial rewrite.
epee namespace appears to be using ssize_t
everywhere std::size_t
occurs. since size_t is not always portable, this could be the reason... but can we need to make sure that std::size_t
should indeed be a ssize_t
as compiler says ... or, if it should be a size_t
as name implies... we should make this clearer.
Other places this was occurring, as far as the linker was concerned:
src/checkpoints/checkpoints.cpp
external/easylogging.h
contrib/epee/include/misc_log_ex.h
src/crypto
&src/crypto/crypto-ops
in various files
Similarly, there is a special case going on with streams. If this is simply for portability -- great. No problems. But make the customized types less confusing