2 issues with the dialog component on ipad safari
Closed this issue · 10 comments
On ipad (with safari):
- The modal won’t open when you tap on it the first time. You have to tap it twice.
- After closing the modal it redirects to a route that isn’t found.
This is on https://salad-storybook.fly.dev/core_components/dialog
Thanks for reporting, I don't have an iPad. Let me try to reproduce on desktop
Here’s a recorded screenshot :-) if I can do anything let me know. https://vimeo.com/966712369
@joepstender are you referring to the redirect when a user dismisses the modal/ dialog?
Yes, by tapping on the X in the top right side corner, or by tapping anywhere else on the screen.
Oh, it's because I open a new link on_cancel event. Updated the example.
The other issue happened on Safari for Mac too. I'm investigating
Now animation is handled by tailwind-animate and this issue would be fixed in PR #22
@joepstender this issue has been fixed. Please verify on your iPad.
https://salad-storybook.fly.dev/salad_ui_component/dialog
Indeed the redirection issue has been fixed on ipad! I still have to tap a second time on the button to open the modal though, which is not the case on https://ui.shadcn.com/docs/components/dialog. There only only one tap is enough. That issue might be hard to debug without an actual ipad…
I suspected that is storybook issue.
This issue occurred on my iPhone, but when I switch to playground, it doesn't happen any more
Yeah, I suppose we can close this issue.