bmuschko/gradle-docker-plugin

Conflict with shaded dependency from gradle-docker-plugin

smirnovdvde opened this issue · 4 comments

There are shaded dependencies in gradle-docker-plugin. If in the build gradle script in project there is another gradle plugin or something in buildscript classpath, that uses, for example, docker-java-api, which is shaded in the gradle-docker-plugin, some conflict among dependencies could happen.

Expected Behavior

There is no shaded dependencies in your plugin. If some conflicts happened, it would be possible to resolve via standard gradle tools.

Current Behavior

Now in case of conflicts between shaded dependencies from plugin and another sources from class path, there is no way to resolve it.

Context

Get stuk with current development of my project.

Steps to Reproduce (for bugs)

Your Environment

I don't fully understand your situation. If a dependency in this plugin was relocated, then it should not have an effect on other plugins that use the same dependency in it's original package. You probably have a situation where a transitive dependency in its original form appears in different plugins. Plugins in Gradle at this time do not have separate classloaders so that's something that needs to be fixed in Gradle itself.

No, it is not in gradle itself, problem is in plugin, i had problem like described here #1144 and i use plugin with version 9.4.0

What I am saying here is that the real solution would be separate classloaders for plugins classpaths in Gradle itself which would not require relocating packages and clashes between dependencies required by plugins.

AFAIR, we had to revert the change you are referring to, as relocating JNA caused issues.

sorry i dont understand, you are writing that "we had to revert the change you are referring to, as relocating JNA caused issues". Does it mean they are already reverted and corresponding version of plugin is released? If yes, i still can observe shaded dependency in version 9.4