bndw/pick

Makefile build target broken

bndw opened this issue · 6 comments

bndw commented

The manual installation steps in the readme fail on the make step.

$ make
GOPATH="/Users/x/code/pick:/Users/x/code/pick/vendor" go get github.com/rogpeppe/godeps
GOPATH="/Users/x/code/pick:/Users/x/code/pick/vendor" /Users/x/code/pick/vendor/bin/godeps -u dependencies.tsv
/bin/sh: /Users/x/code/pick/vendor/bin/godeps: No such file or directory
make: *** [goget] Error 127

cc: @leonklingele

bndw commented
test: goget
    GOPATH=$(GOPATH) go test -v $(FOLDERS)

We should be able to achieve the same functionality with go test -v ./...

I'm sorry! Fixed with #30

Regarding go tests: What's the problem with the way it is in Makefile?

bndw commented

Both methods will certainly work; my suggestion simply uses the go tool directly rather than also using find.

Your command will also run the unit tests from all vendor/ packages, which should avoided IMO.

bndw commented

Good point