boa-dev/criterion-compare-action

It doesn't create comments from fork projects

mgrachev opened this issue · 2 comments

mgrachev commented

Hi there and thank you for this useful project!

I'm facing the problem that this project doesn't create comments in PR's from fork projects.
dotenv-linter/dotenv-linter#425

The output:

/usr/share/rust/.cargo/bin/critcmp master changes
group                            changes                                master
-----                            -------                                ------
dotenv_linter check              1.00     71.1±4.59µs        ? ?/sec    1.00     71.1±3.90µs        ? ?/sec
dotenv_linter compare            1.00     58.5±2.38µs        ? ?/sec    1.02     59.4±2.70µs        ? ?/sec
dotenv_linter fix                1.24  242.3±233.02µs        ? ?/sec    1.00   195.3±15.41µs        ? ?/sec
dotenv_linter fix with backup    1.07  260.3±130.14µs        ? ?/sec    1.00   243.3±20.08µs        ? ?/sec
┌─────────┬─────────────────────────────────┬───────────────────┬─────────────────────┬────────────┐
│ (index) │              name               │  changesDuration  │   masterDuration    │ difference │
├─────────┼─────────────────────────────────┼───────────────────┼─────────────────────┼────────────┤
│    0    │      'dotenv_linter check'      │   '71.1±4.59µs'   │    '71.1±3.90µs'    │   '0.0'    │
│    1    │     'dotenv_linter compare'     │ '**58.5±2.38µs**' │    '59.4±2.70µs'    │   '-2.0'   │
│    2    │       'dotenv_linter fix'       │ '242.3±233.02µs'  │ '**195.3±15.41µs**' │   '+24'    │
│    3    │ 'dotenv_linter fix with backup' │ '260.3±130.14µs'  │ '**243.3±20.08µs**' │   '+7.0'   │
│    4    │               ''                │     undefined     │      undefined      │   '+NaN'   │
└─────────┴─────────────────────────────────┴───────────────────┴─────────────────────┴────────────┘

If the PR is not from a fork project, it works perfectly
dotenv-linter/dotenv-linter#424

The output:

/usr/share/rust/.cargo/bin/critcmp master changes
group                            changes                                master
-----                            -------                                ------
dotenv_linter check              1.01     75.2±5.01µs        ? ?/sec    1.00     74.3±4.73µs        ? ?/sec
dotenv_linter compare            1.05     64.6±4.04µs        ? ?/sec    1.00     61.8±5.43µs        ? ?/sec
dotenv_linter fix                1.00   194.5±16.18µs        ? ?/sec    1.10   213.8±20.74µs        ? ?/sec
dotenv_linter fix with backup    1.00   260.8±24.35µs        ? ?/sec    1.05   273.3±73.96µs        ? ?/sec
Razican commented

This is a known GitHub issue, maybe @jasonwilliams can give more insights.