boa-dev/criterion-compare-action

Unrecognized option: 'save-baseline'

Closed this issue · 4 comments

CastilloDel commented

When I try to use this extension, I get the following error:

error: Unrecognized option: 'save-baseline'
error: bench failed
Error: The process 'cargo' failed with exit code 101
    at ExecState._setResult (/home/runner/work/_actions/jasonwilliams/criterion-compare-action/move_to_actions/dist/index.js:1:7880)
    at ExecState.CheckComplete (/home/runner/work/_actions/jasonwilliams/criterion-compare-action/move_to_actions/dist/index.js:1:7442)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/jasonwilliams/criterion-compare-action/move_to_actions/dist/index.js:1:6406)
    at ChildProcess.emit (events.js:210:5)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)
Error: Unhanded error:
Error: The process 'cargo' failed with exit code 101

CI run
It seems like it is trying to use an option that doesn't exist.
I tried with criterion 0.3.5 and 0.3.3

CastilloDel commented

Related bheisler/criterion.rs#193 Seems like it happens because I also have tests apart from the benchmarks, but it should still work

CastilloDel commented

This workaround seems to work. Maybe this should be documented in the README?

brainstorm commented

@CastilloDel ... it indeed seems strange because that -- --save-baseline is in the main.js for this action in:

https://github.com/boa-dev/criterion-compare-action/blob/master/main.js#L37

I suspect that the --save-baseline master fails because the action is executed in the context of a pullrequest and therefore it should not push to master (until merged to it?).

I'll try to re-run it on our CI and test...

Razican commented

--save-baseline will only save a local copy of the results of the benchmarks, so it should work. The workaround seems to make sense, maybe we could add it to the README, feel free to open a PR :)