boatbomber/WindShake

Add APIs to modify radius of active shake objects

ShadowEngineer opened this issue · 0 comments

src/init.lua:136 has 2 hardcoded values that I think deserve to have APIs to change them with.

local updateObjects = self.Octree:RadiusSearch(cameraCF.Position + (cameraCF.LookVector * 115), 120)

In my use-case, I find that a 120 stud radius is simply not large enough to make the shake immersive enough.
I use WindShake's wally package version and therefore cannot edit the source code directly (or rather, ideally should not).

I think these 2 values can be amalgamated into a single property of the WindShake module:

WindShake.ObjectRadius: number

Changing this value manually from one's own code will then be the viable way to change the octree search radius without modifying source code or forking the repo.

I do realise that this repository has not received an update in a while and this is a very minor issue, but, worth changing?