bobosch/ods_osm

Implement radial zipcode-search

Opened this issue · 4 comments

A colleague of mine and myself we would like to help implementing a radial zipcode-search for your extension. Our current proposal is to use the same implementiation as https://extensions.typo3.org/extension/myleaflet does. It uses SQL to calculate the the radius for a given zip https://github.com/joachimruhs/myleaflet/blob/master/Classes/Domain/Repository/AddressRepository.php If you don't like that approach (it's not the cleanest one we think) we're open for better solutions aswell. We aim to extend your extension in close consultation with you, so that you are willing to implement our code as soon as it's finished.
What's your opinion on this, @bobosch ?

albig commented

This sounds interresting. There has been a radial search extension to ods_osm by @bobosch up to TYPO3 8: https://extensions.typo3.org/extension/ods_osm_search. I have never had a look at it and cannot say how much effort is needed, to get it working with current ods_osm. I think, it would only be possible to inspire a new implementation.

For which TYPO3 version do you plan to implement this feature? The current major version is for TYPO3 11 & 12. But I'm experimention already with a partly rewritten future version for TYPO3 12 & 13.

Ah, thx for your input regarding the old extension. We'll have a look at it. We hope to be able to implement it for T3 12 then.

I also did some research about this topic a few days ago and found this page: https://mysql.rjweb.org/doc.php/find_nearest_in_mysql

An easy solution would be to use the "bounding box implementation" in my opinion. The implementation in the mentioned AddressRepository is slow and the database needs to calculate the distance for every single record which is a waist of resources.

thx @simonschaufi for your input! we'll have a look at it