bokuweb/re-bulma

Production release expectation!

baljeet opened this issue · 10 comments

baljeet commented

Are there any plans to have a production release for re-bulma? This repo looks very promising.

bokuweb commented

I want to catch up original bulma.css and rethink css in js. 🙏

  • 👍2
  • ❤️1
dav-is commented

Update?

bokuweb commented

Sorry... not yet.

  1. I would like to use react v16, because multiple react element can return in render method. Then We need to adjust each components.

  2. I would like to automate catch up original bulma css with using styled-components (or other).
    But it seems time consuming. I have not started yet....

dav-is commented

On the plus side, I hear React 16 is coming sometime next week

nightwolfz commented

Well, it's out now :)

  • 👍1
  • 😄1
kresli commented

Thank you for this project!

However I think the whole project need to be updated. I tried to develop on it, but I've got couple errors. Hopefully I will have time to update this with following changes.

  • use create-react-app (including react 16)
  • remove karma (I dont see any test) and replace it by jest and snapshot tests
  • update outdated packages
  • replace class conation by classname package

I just starting new project and I choose bulma for the flexibility, looking forward to start contribute, but really the project need to be updated. Will create pull request.

bokuweb commented

@kresli Thanks.

use create-react-app (including react 16) 👍
update outdated packages 👍
replace class conation by classname package 👍

remove karma (I dont see any test) and replace it by jest and snapshot tests

But, I would like to use avaron (https://github.com/bokuweb/avaron). Because It is able to use snapshot and taking screenshot (It is useful to do visual regression test.)

bokuweb commented

And I would like to add flowtype annotation....

kresli commented

avaron - In your project you are using styleguidist. Isn't that enough?
flowtype - To be honest I tried flowtype and run into more issues then resolved. However, that was time ago so maybe its more stable. I'm big fun of react + typescript and I could easily convert components to typescript if necessary.
Both request could be added later as plugins and because I dont have much experience with any of those, I would skip this in PR and leave it for another one. I already working on it, will see whats we'll get :)

  • 😄1
bokuweb commented

Ok, I'm sure.