Arrow keys bug (not selecting) when navigating a 'hoisted' outline
Closed this issue · 10 comments
Selection is not set properly when navigating with the keyboard in an hoisted part of the outline
Maybe the 'isRoot' flag was wrongly included in the key hash string id for outline node - or something similar is affecting the key hash string 'id' when hoisted.
Body pane changes correctly, so its the selection (node id when recealing and setting selection in vscode's tree) that's wrong when hoisted
After investigating, bug is in leoIntegration.ts, in method apToLeoNode.
The stack of nodes (in the archived position json) when hoisted past the first level, (not child of the hidden root node) is inconsistent and node ids are based on stack, so after making nodes for the outline to display there is a mismatch of ids when creating the node for the 'reveal' method. (which makes the selection in the tree)
Relevant experimental code in the devel branch at the start of apToLeoNode method in place for now, I'll finish debugging this probably this weekend.
Found it: get parent continues past hoisted node. I'll intercept in leointeg's getParent. (no need to modify the server.)
@edreamleo Nope, not in the near future. The last I've added a couple weeks ago is the '@Wrap' status in the 'get states' method.
After Leo 6.6 is released, I'll add @Wrap support to LeoInteg, making use of this new data in the json retrieved from the server.
@edreamleo oh well.. I talked too fast: I just did add a new feature to the server!
But I wont add more until you release 6.6 as I need people to update their Leo before I can add those cool new features to LeoInteg ! 😁
@edreamleo No problem :)
Fixes have been merged in master