Update project structure to follow new Sketch plugin guidelines
guerrero opened this issue · 7 comments
Inspired by this repo, I'm creating my own commands and most of them have been borrowed from yours so, if you're interested, I can create a PR to update this repo structure. Some of these changes would be:
- Replace
.jstalkby.cocoascript - Create a
.sketchpluginfolder - Add a
manifest.jsonfile - Add a nodeJS task to update
manifest.jsonwhen new files are added or updated into the sketch plugin folder
That sounds awesome, and it's something I'd do myself if I had the time, so I'll happily merge a pull request with these changes from you : )
Awesome! Will review and merge in a minute : )
@bomberstudios Great! Thanks for your support, also I've seen some other changes that can be done to improve the repo and save some lines of code. Some of them are the following:
- Delete sandbox file and modify files that uses sandbox methods
- Remove semicolons due they are unnecesary in CocoaScript
- Add two tasks, one to update manifest and the other one to copy this repo into your sketch plugins folder and update it when files are changed to improve development and testing
I've also other recommendations and propositions, like use dot notation to support linting tools, but I don't know if you're interested and I don't want to be like a spammer opening a lot of issues at the same time so, if you wish, I can proceed creating some issues.
Thanks!
Delete sandbox file and modify files that uses sandbox methods
Just did this locally, so I'll take it and will push in a minute.
The rest look reasonable, and I'd love to get pull requests for them : )
Nice! I'll create them in the next few days.
P.S. Thanks to mention me in your README's Thanks section!
P.S. Thanks to mention me in your README's Thanks section!
It's the least I could do!