bonnici/node-steam-trash-bot

Crash on trade offers via the /tradeoffer URL

Closed this issue · 9 comments

stmps commented

Howdy,

node-steam-trash-bot crashes for me when sending trade offers via the /tradeoffer URL.

e.g. http://steamcommunity.com/tradeoffer/new/?partner=foo&token=bar

Console output is as follows:

2014-06-20T00:24:03.129Z - info: tradeOffers event 0=1

events.js:72
    throw er; // Unhandled 'error' event
          ^
Error: spawn ENOENT
    at errnoException (child_process.js:988:11)
    at Process.ChildProcess._handle.onexit (child_process.js:779:34)
bonnici commented

Still working for me, has it ever worked for you? May just be a hiccup on the steam servers during the sale.

stmps commented

Hey dude,
Hmm. It has never worked for me. I also have some problems in completing regular (interactive) trades - the trashbot won't check his ready' box in response to mine.

It also seems to randomly ignore when I paste item URLs into the trade chat. There is no log output after "Instruction messages sent to x".

Actually there we go - 2 minutes later I got "Trade ended with status empty."

I wonder if the steam account is in a weird state?

edit: full log of my broken trades:

2014-06-20T09:36:57.713Z - info: Trade from foo proposed, ID 12345
2014-06-20T09:36:57.713Z - info: Responding to trade
2014-06-20T09:36:58.325Z - info: sessionStart xxx
2014-06-20T09:36:58.326Z - info: setting cookie sessionid=xxx
2014-06-20T09:36:58.326Z - info: setting cookie steamLogin=aaa%bbb
2014-06-20T09:36:58.601Z - info: steamTrade opened with foo
2014-06-20T09:37:05.335Z - info: Instruction messages sent to foo
2014-06-20T09:39:45.443Z - info: Trade ended with status empty
bonnici commented

Try logging in using the account through steam to see if anything weird is going on. If you can do trades through steam it should work using the bot.

stmps commented

I logged in with the bot account with the steam fat client, and successfully traded an item in both directions (giving it away and accepting it back again.) Using an interactive trading session via "invite to trade". No problems there.

But when trading with the bot.js instance, it still never accepts my trade proposal. It just times out, like so:

2014-06-22T09:51:09.897Z - info: steamTrade opened with 1234
2014-06-22T09:51:12.285Z - info: Instruction messages sent to 1234
2014-06-22T09:51:26.944Z - info: friendMsg event for 1234 entryType 6 message
2014-06-22T09:52:02.749Z - info: Trade ended with status cancelled

Argh!!!

Is there some way to print some debug output to work out what it's doing?

bonnici commented

Sorry I'm not sure what might be causing that, my best guess is that it's some weirdness caused by load due to the sale. You can try catching errors by using:

process.on('uncaughtException', function(err) {
console.log('Caught exception: ' + err);
});

And that might give you some hints.

stmps commented

Thanks dude, I'll give it a go.
(Where do I put that code? Just after the global variables in bot.js?)

bonnici commented

Anywhere within bot.js should work I think

stmps commented

weird. That doesn't help with the interactive trade failures because
there's no exception to throw - it either sits in the trade window and
refuses to click "OK to trade", or times out after a couple of minutes.

is it possible that some of my dependencies are broken? I'm not sure what
libraries are required for it to be able to accept a proposed trade...

(Offline trade offers are throwing exceptions but I'm not as interested in
them.)

On 24 June 2014 15:24, bonnici notifications@github.com wrote:

Anywhere within bot.js should work I think

—
Reply to this email directly or view it on GitHub
#2 (comment)
.

bonnici commented

Have you set up PhantomJS? You should be able to uncomment the "this.capture" calls in accept-trade-offers.js to see a screenshot of what's happening after each step of the trade.