Bookie tests failing; need to fix installation for Travis CI
craigmaloney opened this issue · 5 comments
@miso-belica pointed out that the tests for Bookie are failing. That's part of the issue. The other part is that Bookie is not currently able to build because certain packages have aged out and are no longer available. I don't remember the specifics at the moment so I can't elaborate more without re-trying the build process. What I remember though is I got stuck while trying to modernize the packages with later versions.
@craigmaloney Can you give me some info about breadability/bookie? My story is that I use breadability in https://github.com/miso-belica/sumy and did some changes into in the past. It's quite a while :)
From my point of view I guess we could remove support for old Py2.6 if possible or maybe even Py3.3. But I am not sure about it. I can live with it in sumy.
Also I would refactor tests to run using pytest and I would remove unittest2 package then if possible. I can see there is some old branch port-pytest but it seems there is still old "good" unittest. I can help with refactor to pytest if you are interested and you (or anybody) can do me a review. And also fix the 2 failing tests with it.
What do you think?
I was speaking on the project as a whole. I don't think the current batch of tests can be run on breadability by itself.
I hate to say the word "fork" but I'm wondering if it's time to fork off breadability on its own until if / when Bookie can be modernized. Are you currently maintaining a branch?
Hmm, sorry, but I don't use bookie and I don't even know what exactly it is. I always though some kind of Readability app fork? But I don't see how breadability fork help here. If problem is somewhere else in bookie stack I think it should be fixed there. I believe breadability can be fixed right here.
I can help with porting to pytest and fix the failing tests if dropping py2.6 support is not option and someone will do me a review, but I don't think I can help with other bookie packages. If you can write how breadability is blocking some other package to upgrade maybe I can fix also that issue, but that's all.