`Matrix::qrR` usage in R/factorize.R

[jaganmn]

Hello,

Your package, FDboost, has:

FDboost/R/factorize.R

Lines 171 to 174 in d948f05

	R <- lapply(QR, lapply, function(x) {
	if(inherits(x, "qr"))
	qr.R(x)[, order(x$pivot)] else
	qrR(x, backPermute = TRUE) })

but qrR may be deprecated in favour of qr.R as soon as Matrix 1.6-0 (to be released in July), although to give package maintainers more time we may delay the deprecation to a later version.

To be backwards compatible with earlier versions of Matrix, I would patch your code like so:

R <- lapply(QR, lapply, function(x) {
    j <- if(isS4(x)) x@q else x[["pivot"]]
    if(is.unsorted(j))
        qr.R(x)[, order(j), drop = FALSE]
    else qr.R(x) })

rather than simply replacing qrR with qr.R. Let me know if you think that you could make such a change before July, or if you think that you need more time. Well, in any case, it would be good to verify that your package passes its checks under Matrix 1.6-0, which you can install with install.packages("Matrix", repos="http://R-Forge.R-project.org").

Thanks,

Mikael { Matrix package co-author }

[jaganmn]

I have jumped the gun a bit with this issue. After more complete rev. dep. checking and discussion, we have decided to not go ahead with the deprecation. Sorry for the noise. Still, the is.unsorted check is worth thinking about - it may save time/memory where the permutation is just the identity permutation.