CMake inconsistency, use namespace Boost::callable_traits as library name

Question

CMake inconsistency, use namespace Boost::callable_traits as library name

Closed this issue 5 years ago · 4 comments

In the main CMakeLists.txt, I can find add_library(callable_traits INTERFACE) which is inconsistent with the conventions used by the 29 other Boost libraries that Boost::histogram (indirectly) depends on, see e.g. Boost::mp11, Boost::assert, Boost::config. They use the library name Boost::something.

Please add the following line to provide a conforming alias
add_library(Boost::callable_traits ALIAS callable_traits)

Answer 1 · 2019-04-14T13:59:45.000Z

There is another problem: the master CMakeLists.txt needs an
if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) around the tests, so that they are not loaded if callable_traits is used as a dependency by another project. An example on how to do this is given by mp11, https://github.com/boostorg/mp11/blob/a03e644dc70facf7318432ce9bb86da9009d3944/CMakeLists.txt#L17

Answer 2 · 2019-04-23T12:57:59.000Z

Thanks! I'll get the fix merged in this week.

Answer 3 · 2019-04-23T13:04:36.000Z

Great, I am looking forward to it. 👍

Answer 4 · 2020-03-25T02:45:42.000Z

Closing because the PR was merged...