boostorg/math

boost/math/tools/constexpr_workarounds.hpp not found

WillemvJ opened this issue · 6 comments

I am trying to use boost/math as a submodule in a program with c++20, but I am getting problems. I added boost.math as a submodule like so:

git submodule add https://github.com/boostorg/math.git src/extern/boost_math

(I also tried adding specifically the master branch)

I include it in my root cmakelists like so:

add_subdirectory(src/extern/boost_math)

I add an executable and link it like so:

target_link_libraries(${targetname} PRIVATE Boost::math)

Now, I make a small test program in which I do

#include <boost/math/distributions/binomial.hpp>

However, I get:

Error C1083 Cannot open include file: 'boost/math/tools/constexpr_workarounds.hpp': No such file or directory

this is inside math/special_functions/round.hpp and one other spot.

Am I trying something which is not supported? Or am I doing something wrong? The file really does not seem to reside in tools folder.

This affects Boost.Integer tests, see here for example.

And the problem is also present in master, so it also affects the upcoming 1.84 release.

Looks like this was introduced in d938d3e. CC @jzmaddock.

pdimov commented

Yeah, I also noticed this and was going to open an issue, but I see others have already done so. :-)

Looks like some code changes got committed by mistake.

Hi Matt and John (@jzmaddock) and (@mborland).

I can confirm this error also in nightly CI for several of my own projects that use math.

Maybe forgot to add the file to source control?

Commit has been reverted on master. Like Peter said it looks like a few working changes accidentally got picked up in the doc update. Sorry about that.

Commit has been reverted on master.

... and develop.

Thank you Matt (@mborland). Now perfectly fine are all 3 of my failing CIs in unrelated projects.

OMG, really really sorry about that, and I do always review the diffs before committing, but somehow missed that! :(