Use boost::swap instead of std::swap for swapping key/comp_ function objects

Question

Use boost::swap instead of std::swap for swapping key/comp_ function objects

valziegler opened this issue 5 years ago · 4 comments

void ordered_index_impl<...>::swap_(ordered_index_impl<...>& x) uses std::swap for swapping the key and comp_ functors. Is there any particular reason for not using boost::swap here?

Answer 1 · 2019-11-08T12:30:49.000Z

Hi,

No, there's no particular reason why ADL-enabled swap is not used, and in fact the current behavior is in disagreement with [swappable.requirements]. Will fix this in a few days.

Answer 2 · 2019-11-08T12:33:34.000Z

Thank you!

Answer 3 · 2019-11-09T12:03:12.000Z

Fixed in 3caea31, care to check?

Answer 4 · 2019-11-11T13:32:03.000Z

adl_swap works for me, thanks again.