fix: UINT comparison not working
mmackz opened this issue · 2 comments
mmackz commented
Is there an existing issue for this?
- I have searched the existing issues
Package Version
alpha.13
Current Behavior
When comparing UINT, the filterData has to be in hexadecimal form, and the fieldValue can be a bigInt.
For example, if we wanted to match a tokenId with the value of 3n, it would compare "0x03" with 3n which resolves to false.
Expected Behavior
Normalize the hexadecimal and field values so they can be compared properly.
Steps To Reproduce
Input a value as a hexadecimal string and have it compared to a field value that is a bigint.
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
No response
sammccord commented
i think we should run everything through https://viem.sh/docs/utilities/fromHex based on the primitive type before comparing
topocount commented
@sammccord I'm already working on this 😬