[CLOSED] IE11 and console.log()
Waxolunist opened this issue · 8 comments
Issue by SiamKreative
Monday Jun 16, 2014 at 04:58 GMT
Originally opened as Waxolunist/bootstrap3-wysihtml5-bower#56
Hello there,
In one of our WordPress plugins, we use bootstrap3-wysihtml5.all.min.js
.
Because of a console.log();
in this file, the javascript was not executed. Please see this comment on StackOverFlow.
Could you remove the console.log() or make sure it works on IE?
Cheers
Comment by Waxolunist
Monday Jun 16, 2014 at 14:23 GMT
The console log comes from a dependency. I will see, what I can do. Either I can remove it upon build or add a wrapper.
Comment by Waxolunist
Monday Jun 16, 2014 at 14:46 GMT
Are you on the 0.3.x branch?
I just committed a fixed version. I don't have IE11 at hand. Can you confirm that it is working by using the current 0.3.0-wip branch? If you are using bower, changing the version should fix it.
If so, I will release two tags, one for the 0.2.x and one for the 0.3.x version, because this is a blocker.
BTW: Is your wordpress plugin open source or public? If so, I would like to link it.
Comment by Waxolunist
Monday Jun 16, 2014 at 20:50 GMT
I just tested the release 0.3.1 on a vm with Windows 8.1 and IE 11 but I can not reproduce your problem. How can I reproduce your issue?
Comment by SiamKreative
Tuesday Jun 17, 2014 at 03:24 GMT
Thanks for getting back to me. Unfortunately our plugin is a premium plugin. It uses version 0.2.10-alpha.2. Lemme try with the WIP version.
Comment by Waxolunist
Tuesday Jun 17, 2014 at 07:08 GMT
I really suggest using the newest 0.3.x versions because 0.2.x depends on a wysihtml editor repo not maintained anymore.
I tested the 0.2.x branch with console.log and can not reproduce your issue. But I will remove it upon build also in the next 0.2.x release. I just pushed the fix to master. If you can confirm that it is working, I will make an release.
I would like to link your company from my repo in a "Used by" section if this is ok for you. I'd appreciate, if you write a short 1-2 sentence teaser for this section.
Comment by SiamKreative
Tuesday Jun 17, 2014 at 08:02 GMT
Sure, the WordPress plugin is Awesome Support and our brand is ThemeAvenue :)
I haven't tried the newest 0.3.x version yet. Using Bower, do you know how to specify the dev branch?
Cheers
Comment by Waxolunist
Tuesday Jun 17, 2014 at 15:53 GMT
Just specify 0.3.0-wip as version.
Or for the 0.2.x "master".
PS: Thx for the links.
BTW: If you are using FontAwesome: 0.3.1 has support for it.
Comment by Waxolunist
Friday Jun 20, 2014 at 05:58 GMT
Ok, I will release with the fix this weekend in both branches. Thus I am closing. If you still got problems after the next release, please reopen this issue.