boppreh/steamgrid

Some games not being recognized

Hexprian opened this issue · 6 comments

Steamgrid does recognize 3 of the 92 games in my library (launching it makes it look for artwork for the 89 games remaining which works correctly).

All 3 of these games are non-Steam games: Xenoblade Chronicles - Definitive edition, The Legend of Zelda: A Link to the Past and Zelda II: The Adventure of Link. The three of them are being launched via Baileysoft Games Launcher, but other games of my library are launched in similar conditions and they show no problem being recognized.

I'm ussing version 3.2.1 with all 12 new comits as of today. This problem did not occurwithout the comits, but since Steamgrid wasn't working at all without them it's still an improvement.

Lucki commented

Looks like their api has an additional nesting in the search response now:

https://www.steamgriddb.com/api/v2#operation/searchGrids

{
  "success": true,
  "data": [
    {
      "success": true,
      "data": {
        "id": 0,
        "name": "string",
        "types": [
          "string"
        ],
        "verified": true
      }
    }
  ]
}

steamgrid/download.go

Lines 89 to 97 in c796e61

type steamGridDBSearchResponse struct {
Success bool
Data []struct {
ID int
Name string
Types []string
Verified bool
}
}

Lucki commented

Despite their api docs claiming otherwise, there isn't an additional nesting in their response. We're still correct in the code and my custom shortcut "The Legend of Zelda: A Link to the Past" was correctly found.

Can't reproduce, needs more info.

Are the images present in the grid folder?
If so: Is the id different from what is assigned by steam when manually setting an image?

After giving up on trying to use this app for those games, I chose to manually pick all 4 types of images those 3 games, resulting in the creation of 12 new files in the Steam/Grid folder. Nothing strange there.

Some weeks later i decided that I wanted to play some pokemon, so I downloaded and set up to launch from Steam via Baileysoft these games:
"Pokémon Omega Ruby"/"Pokémon Rubí Omega"
"Pokémon White Edition 2"/"Pokémon Versión Blanca 2"
"Pokémon Sword"/"Pokémon Espada"

When this app was applied, Pokémon Sword was not recognized at all as a game, meaning that Steamgrid correctly applied grids and overlays to 94/94 games but it should be instead saying 98/98, ignoring Pokémon Sword and all 3 I was having problems with before.

This afternoon I saw your answer and decided to try something. At first I had those pokemon games with their English names, but decided to change them to Spanish for... reasons. "Pokémon Rubí Omega" and "Pokémon Versión Blanca 2" were not correctly found, some generic Pokémon Red images were chosen, but that's not the point, the thing is, well, even if it wasn't correct something was picked. What would happend if I changed "Pokémon Versión Blanca 2" name in Steam to "Tetris"? Generic Tetris 2 images showed up. And then, what would happend to "Pokémon Sword" if I also changed its name to "Tetris" and deleted my manually created files? ... Nothing, just as before 94/94 games and no changes were applied.

I don't know what all this exactly means but maybe, just maybe this isn't an Steamgrid bug, but Steam's.

Lucki commented

Steam changed the shortcut format a bit in the last winter. Baileysoft hasn't seen a new commit in 3 years and I currently suspect they are missing the newly introduced appid we're relying on.

Please create a new shortcut from within steam and then replace all properties with the properties from shortcut from Baileysoft.

I created new shortcuts from within steam for "The Legend of Zelda: A Link to the Past" (Snes9x), "Pokémon Sword" (yuzu) and "Zelda II - The Legend of Link" (mesen). All of them were correctly recognized and images were applied. This still doesn't solve everything since I just noticed "Xenoblade Chronicles - Definitive Edition" was not being launched through Baileysoft and the shortcut pointed to yuzu, exactly as "Pokémon Sword".

Lucki commented

Ok, thanks for confirming that steamgrid works correctly.
Remaining issues are related to user configuration and/or third party shortcut creation tools.