What is com.twitter.commons:zookeeper:0.1.1?
Closed this issue · 5 comments
I see the jar in boundary's repo here, but not in twitter's repo here or here, and I see nothing else relevant on google.
Judging by these two issues on twitter/commons,
it sounds like there's a forked boundary repo somewhere that was going to get merged back upstream, but it got stalled. If so, what's the status of that? Is the source available, at least?
I'm interested because I just tripped a ZooKeeperClient bug that was recently fixed, and I'd like to upgrade to one of the more recent com.twitter.commons.zookeeper:client versions, or at least apply the twitter patch to com.twitter.commons:zookeeper:0.1.1 in the meantime.
Clarification: I do have the source jar for com.twitter.commons:zookeeper:0.1.1 from here, but I'm wondering if there's a repo somewhere that I can fork and push the twitter patch to. Alternatively, I might just make an ad-hoc repo from the source jar or something.
Ad-hoc repo created and patched. I'll go with this for now. The questions above still stand.
Just diagnosed and fixed another bug in ZooKeeperClient that was causing onLeave/onJoin races around cluster expiration when using jdanbrown@4f8f71b from #15, which exposes the race because it causes the ZooKeeperClient watchers to be registered in a different order. Turns out twitter fixed this ZooKeeperClient bug upstream a long time ago.
This is another request to resolve twitter-archive/commons/pull/11 so we can sync up with the latest twitter/commons and avoid some of these issues. ;) What needs to be done—maybe I can help?
twitter-archive/commons#165 was just merged. Hopefully there will be a release soon that will allow ordasity to be updated to use it.
Release 0.5.8 of Ordasity is now available. This switches to the upstream Twitter Commons ZK client. There is a small API difference - ZKMapListener is just Listener in the upstream client, so you will need to update your imports accordingly.