boxen/puppet-hub

Why is the default value for `hub.protocol` set to `true`?

am opened this issue · 2 comments

am commented

The title says it all, currently I override this value to git:

git::config::global { 'hub.protocol':
  value => 'git'
}

I would like to know why the module changes this hub default.

Thank you ;)

[UPDATE]
When I try to override the configuration I get a duplicated declaration error as this was pervious defined by the hub module:

Error: Duplicate declaration: Git::Config::Global[hub.protocol] is already declared in file /opt/boxen/repo/modules/people/manifests/am/repositories.pp:56; cannot redeclare at /opt/boxen/repo/shared/hub/manifests/init.pp:15 on node am.local.com

"hub.protocol" is "https" by default since (I'm guessing) the GitHub team mostly uses HTTPS internally.

However, I don't think this is a good default for everyone. I would much rather that Boxen doesn't set this by default.

This should be fixed in #8 – we're going to leave the https default, but should be easy to change now