bpatrik/pigallery2

Incorrect thumbnail aspect ratio

balonchiks opened this issue ยท 11 comments

Hi, thanks for the great little gallery. I've noticed that some vertical photo thumbnails show up incorrectly in album view, for example:
the original photo dimensions are 3323x4430 (that's from EXIF) but the gallery detects the dimensions as 1x1 (shows this size when viewing full size photo and clicking "i" button) and hence shows the photos thumbnail as being squarish. It is worth to note that the thumbnail itself is of a proper aspect ratio, it's just how the gallery displays it (streches to square) due to incorrect size detection.

Can you pls take a look at the issue? thanks!

Hi,

Can you maybe send me a photo that shows this error?

Patrik

there you go. that's a different one dimensions-wise but still has the same 1x1 size when viewed full size

this might be helpful...:

i normally edit all my photos in Lightroom, however, some of them i do export to Photoshop directly to lightroom, and after saving back from PS to LR, the files are saved as .tiff

so the issue seems to be with these files that were processed in PS ot LR and then exported to .jpg

looks like PS do modify EXIF in some way...

I think I managed to fix it with the latest commits. Its not part of any release yet, but you can also build it from source.

thanks, building from source solved the problem :)

Using the docker release: bpatrik/pigallery2:nightly-stretch pulled just now, I still see the issue with some images. Was it supposed to be fixed at this point?

I can attach the problematic images if relevant.

Hi,
yes, this should work by now. Can you please attach that photo?
I'm reopening the issue.

Just a note: pigallery does this correction on the client side that slows down the page. If you have only a few photos that needs to be rotated that's fine, but if you have more I recommend to fix the original files to have a smooths experience.

Thanks for looking in to this, here are two examples: test test2

The issue seems to happen for all pictures taken in portrait from the frontfacing camera on my smartphone, the first photo test.jpg is an example of that. The second, which is a png, might trigger a different issues as it has no exif data (I believe).

Hi

Thanks for the photos, I manged to fix the error.

Patrik

I just pulled the bpatrik/pigallery2:nightly-stretch docker and can confirm that the proportion issue is fixed for my photos, thanks!

Hi, I have the same issue, can I send you the jpg file?