bpmn-io/bpmn-js-examples

Update properties panel examples to the new API

barmac opened this issue · 5 comments

barmac commented

What should we do?

Update examples to account for breaking changes in bpmn-io/properties-panel#134

Why should we do it?

The examples should be up to date.

Related to #135

pinussilvestrus commented

Thanks for creating this issue 👍
Another thing to update: https://github.com/bpmn-io/properties-panel-async-example, which I can take care of.

Cf. bpmn-io/properties-panel-async-example#2

MaxTru commented

We will do this, after we released 1.0.0 stable

shade-belisar commented

When I try to run npm install in properties-panel-extension I get the following error:

npm ERR! Could not resolve dependency:
npm ERR! peer @bpmn-io/properties-panel@"0.11.x" from bpmn-js-properties-panel@1.0.0-alpha.5
npm ERR! node_modules/bpmn-js-properties-panel
npm ERR!   bpmn-js-properties-panel@"^1.0.0-alpha.0" from the root project

Am I correct in assuming a relation to this issue? Or is that a separate problem that I should report?

MaxTru commented

When I try to run npm install in properties-panel-extension I get the following error:

npm ERR! Could not resolve dependency:
npm ERR! peer @bpmn-io/properties-panel@"0.11.x" from bpmn-js-properties-panel@1.0.0-alpha.5
npm ERR! node_modules/bpmn-js-properties-panel
npm ERR!   bpmn-js-properties-panel@"^1.0.0-alpha.0" from the root project

Am I correct in assuming a relation to this issue? Or is that a separate problem that I should report?

Hi @Adrian-Bielefeldt ,

thanks for spotting! Could you please report a seperate issue? I think this is something we can/should fix even before doing this issue here.

Thanks!

pinussilvestrus commented

Could you please report a seperate issue?

I think this has now already been reported 🙂
#162