bpolaszek/webpush-bundle

Working with Webpack Encore

Closed this issue · 3 comments

Will you plan to modify js code, so that it can work with Webpack Encore?

Hi @vezuwio,

I'm currently working on a SF4 project that uses webpack encore in which I'll need this bundle in a very near future.

So, I'll probably work on it within the next weeks.

Nevertheless, I'm not a JS expert (I never published an NPM package or any JS library), and the current JS implementation is not satisfying to my eyes (hard to figure out who does what) so any help would be really appreciated.

Ben

@vezuwio Just to let you know, I have started rewriting JS from scratch, trying to make it compatible with webpack. Stay tuned.

Hi @vezuwio,

I just released the new 0.4 version. Beware that it has several breaking changes but the main advantage is that the JS part has been completely removed in favor of a standalone component: webpush-client (not natively compatible with 0.3, but can work after some little tuning if you can't upgrade easily).