bpolaszek/webpush-bundle

Incorrect parameter description in services.xml

Closed this issue · 3 comments

wRLSS commented

Configuration file services.xml doesn't seem to be correctly configured in the part of

    <parameters>
        <parameter id="bentools_webpush.public_key"></parameter>
        <parameter id="bentools_webpush.private_key"></parameter>
    </parameters>

I believe it's a mistake and it should state key instead of id.
Having id here introduces some random integer keys with no value inside symfony ParameterBag

wRLSS commented

Any chance it can be released to avoid spreading usage of stability/fork override?

bpolaszek commented

@wRLSS I'm actively working on the 0.4 version, but some little breaking changes are to expect.

bpolaszek commented

0.3.4 released, anyway :)

  • 👍1