bragefuglseth/fretboard

Inconsistent positioning

Closed this issue · 3 comments

Searching for different chords yields inconsistent positions for close chords.

Compare

image

to

image

The two should use the same starting fret as they are actually quite close. 1 makes more sense than 2 as starting fret to me.

Normally, the app tries to position chords so that the neck position is equivalent to the highest fingered fret (closest to the top of the neck). This creates a problem with chords like A, D, Em and G, because the highest fingered fret on those is the 2nd fret, but nobody displays them starting there. I solve that with a special case list. If a chord is in the list, the fret position of it will always be 1. We just need to add this voicing of Esus2 (and any other positioning with the same problem) to that list.

I’ve tried to make it more generic, but I’ve always ran into problems with that, so this is the solution for now.

Thanks for the help with squashing these endless chord issues!