The Great Refactoring

[bragefuglseth]

The current codebase is really messy in places, both style-wise and structurally. I'll have to do some cleanup to make issues like #23 and #16 more realistically solvable. This would hopefully also attract more contributors in the future, lifting the maintenance burden a little.

[orowith2os]

Quick suggestions:

• Move UI files and whatnot to data/resources/ui, rather than src - imo, it's cleaner.
• Migrate to Blueprint for the UI files
• Use an array rather than a Vec when you know the size isn't going to change at runtime - see the "Developers" field in the about window for the primary case where this isn't done. I need to submit a fix to the GTK template and (probably) elsewhere for this.
• The about window builder can be one clean chain of function calls - call .present() on .build(), omit the semicolon, and don't initialize it as a variable. The .transient_for() method can just be this: .transient_for(&self.main_window()). This is what mine looks like, for reference:

    fn show_about_dialog(&self) {
        adw::AboutWindow::builder()
            .modal(true)
            .version(VERSION)
            .transient_for(&self.main_window())
            .application_name(gettext("Toggle"))
            .application_icon(APP_ID)
            .license_type(gtk::License::Gpl30)
            .copyright("© 2023 Dallas Strouse")
            .debug_info(crate::get_debug_info())
            .debug_info_filename("toggle-debuginfo.txt")
            // TODO: set up a website
            .website("https://gitlab.com/orowith2os/toggle")
            .issue_url("https://gitlab.com/orowith2os/toggle/-/issues")
            // TODO: add a link to a public Matrix channel
            //.support_url("")
            .translator_credits(gettext("translator-credits"))
            // To contributors: Feel free to add your name to .developers(),
            // and for those involved with UI, add yourself to .designers()
            .developer_name("Dallas Strouse, et al.")
            .developers(["Dallas Strouse"])
            .designers(["Bart Gravendeel", "Brage Fuglseth"])
            .build()
            .present()
    }

I need to see if one can reuse the release notes from the appropriate appdata file, rather than embedding them in the source code. I'm sure it can be hacked together with Meson.

[bragefuglseth]

Thanks for the suggestions! Most of that is related to the template, fortunately, but I’ll fix it 😄

[orowith2os]

Most of that is related to the template, fortunately, but I’ll fix it

I need to see if I can submit changes for both the gtk-rust-template and the GNOME Builder template, to make them similar and a bit nicer - but from what I've heard from @BrainBlasted, for Builder, that's not too solvable.

[orowith2os]

I need to see if one can reuse the release notes from the appropriate appdata file, rather than embedding them in the source code.

Yep. Unstable, but it's doable. https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/func.show_about_window_from_appdata.html

[bragefuglseth]

I think this issue is too vague to actually be actionable. Closing.