brahmlower/cssef

Json-ify data for Team.model.scoreConfigurations

Opened this issue · 1 comments

Team.model.scoreConfigurations is a string that's supposed to hold a pickled dict. Team.setScoreConfigurations() just saves whatever string it's provided. It should instead take a dict, and then either pickle or json.dumps() that dict, then save the resulting string. Team.getScoreConfigurations() should return a dict representing that string via pickle or json.loads().

Changed this from pickle config data to json-ify data. Pickle introduces additional security concerns which can be avoided by dumping a dictionary to a json string, then storing that in the database.