D++ does not support setting images (e.g) banner through guild_edit

[Mishura4]

It seems the Modify Guild endpoint supports setting images, for example the guild banner, through the guild object. This requires sending the image data encoded as Base64 in the banner field.

cluster::guild_edit takes a dpp::guild as a parameter. However its image fields, for example banner are a utility::iconhash, which do not support base64 strings as they are a pair of integers.

Supporting this will require refactoring those fields as well as how retrieving the image URLs work.

[Jaskowicz1]

I'll fix this :)

[braindigitalis]

please don't change how we store the banner. iconhash is the most efficient storage for it. instead please provide a method for uploading a guild banner without adding variables to the class which will make it bigger and be empty 99.999% of the time

[Jaskowicz1]

please don't change how we store the banner. iconhash is the most efficient storage for it. instead please provide a method for uploading a guild banner without adding variables to the class which will make it bigger and be empty 99.999% of the time

My idea isn't to change how it's stored, but I do need to discuss how to tackle some of the issues on discord.

[Neko-Life]

add a new method to set banner with base64 string. set_banner_base64 that accept string param, possibly with some util to read image file as base64 readfile_base64 for convenience

[Jaskowicz1]

please don't change how we store the banner. iconhash is the most efficient storage for it. instead please provide a method for uploading a guild banner without adding variables to the class which will make it bigger and be empty 99.999% of the time

My idea isn't to change how it's stored, but I do need to discuss how to tackle some of the issues on discord.

i lied

[Jaskowicz1]

I've decided i'm not gonna take the issue :)