brandonroberts/ngrx-store-freeze

This library assumes that all Action's will have a 'payload' attribute

alexjlockwood opened this issue · 1 comments

In earlier versions of ngrx, the Action interface had a payload attribute. This no longer seems to be the case:

https://github.com/ngrx/platform/blob/master/modules/store/src/models.ts#L1-L3

I am wondering if this library needs to be updated to account for this. For instance, in the source code it makes a check if (action.payload):

https://github.com/brandonroberts/ngrx-store-freeze/blob/master/src/index.ts#L19-L21

But what happens when the action uses a different name other than payload?

My suggestion is . to adhere to the current action interface and only use a type property.