brandur/redis-cell

CI fixes welcome?

dbaynard opened this issue · 4 comments

- name: "Get release info"
id: get_release_info
run: |
echo ::set-output name=file_name::${REPOSITORY_NAME##*/}-${TAG_REF_NAME##*/}-${{ matrix.target }}.tar.gz # RepositoryName-v1.0.0-arch.tar.gz
value=`cat release_url/release_url.txt`
echo ::set-output name=upload_url::$value

I noticed this library still uses ::set-output, which is deprecated. The fix (4 lines) shouls be straightforward.

-echo ::set-output name=file_name::${REPOSITORY_NAME##*/}-${TAG_REF_NAME##*/}-${{ matrix.target }}.tar.gz # RepositoryName-v1.0.0-arch.tar.gz
+echo "name=file_name::${REPOSITORY_NAME##*/}-${TAG_REF_NAME##*/}-${{ matrix.target }}.tar.gz" >> "$GITHUB_OUTPUT" # RepositoryName-v1.0.0-arch.tar.gz

I see CI is also throwing rust errors. I don't mind taking a look, if I'm to update the CI anyway. Would a PR be welcome?

Hi @dbaynard, sorry about the really slow response on this one.

Yep, PRs welcome. I haven't taken a look at CI in a while, but I imagine it might need a bit of a modernization pass.

Ah I see you yourself fixed the breakages — it's just the warnings left, now.

I'll PR with the fixes (for deprecated ::set-output, as above, and updates to actions to fix the node.js issue). I'll add Keeping your actions up to date with Dependabot - GitHub Docs too — on a monthly schedule.

Excellent, thank you. And yeah, I pushed a few fixes this afternoon that repaired the most egregious problems.

Going to close this in favor of #68 and related PRs.