Fix segfault in DomainBlockNavigationThrottle
Closed this issue · 5 comments
antonok-edm commented
As per brave/adblock-rust#248:
add these rules to brave://settings/shields/filters
||startpage.com^$removeparam=sc ||startpage.com^$removeparam=t ||startpage.com^$removeparam=cat ||startpage.com^$removeparam=abp ||startpage.com^$removeparam=lui ||startpage.com^$removeparam=qloc
Go to https://startpage.com/do/settings?query= and change the HTTP request method from POST to GET, then save the settings. Brave should crash immediately.
This is likely related to brave/brave-core#15943
kjozwiak commented
The above requires 1.47.176
or higher for 1.47.x
verification 👍
btlechowski commented
Verification passed on
Brave | 1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit) |
---|---|
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241} |
OS | Ubuntu 18.04 LTS |
Reproduced the issue in 1.47.169
Verified in 1.47.177
Steps:
- Open
brave://settings/shields/filters
- Paste the rules below into
Create custom filters
||startpage.com^$removeparam=sc
||startpage.com^$removeparam=t
||startpage.com^$removeparam=cat
||startpage.com^$removeparam=abp
||startpage.com^$removeparam=lui
||startpage.com^$removeparam=qloc
- Click
Save Changes
- Open
https://startpage.com/do/settings?query=
- Change
HTTP request method
toGET
- Click
Save your settings
MadhaviSeelam commented
Verification PASSED
using
Brave | 1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 11 Version 21H2 (Build 22000.1455)
Reproduced in 1.47.171 using testplan from #27791 (comment)
example
Steps:
- Install 1.47.177
- launch Brave
- Click Skip>>Skip>>Finish
- open
brave://settings/shields/filters
- paste the rules below into
Create custom filters
||startpage.com^$removeparam=sc ||startpage.com^$removeparam=t ||startpage.com^$removeparam=cat ||startpage.com^$removeparam=abp ||startpage.com^$removeparam=lui ||startpage.com^$removeparam=qloc
- click
Save Changes
- open
https://startpage.com/do/settings?query=
- change
HTTP request method
toGET
- click
Save your settings
step 6 | step 8 | step 9 |
---|---|---|
![]() |
![]() |
![]() |
stephendonner commented
Verification PASSED
using
Brave | 1.47.177 Chromium: 109.0.5414.87 (Official Build) (x86_64) |
---|---|
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241} |
OS | macOS Version 11.7.2 (Build 20G1020) |
Confirmed crash using the below steps, in current 1.47.171
release:
Steps:
- installed
1.47.177
- launched Brave
- skipped onboarding
- opened
brave://settings/shields/filters
- pasted the following rules into
Create custom filters
||startpage.com^$removeparam=sc
||startpage.com^$removeparam=t
||startpage.com^$removeparam=cat
||startpage.com^$removeparam=abp
||startpage.com^$removeparam=lui
||startpage.com^$removeparam=qloc
- clicked
Save changes
- loaded
https://startpage.com/do/settings?query=
- changed
HTTP request method
toGET
- clicked
Save your settings
Confirmed no crash
example | example | example |
---|---|---|
![]() |
![]() |
![]() |
Uni-verse commented
Verified on Samsung Galaxy S21
& Samsung Galaxy Tab S7
using the following version(s):
Brave 1.47.181 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Android 13; Build/TP1A.220624.014
Brave 1.47.181 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Android 12; Build/SP2A.220305.013
STR:
- Open brave://adblock for mobile
- Paste the rules below into Create custom filters
||startpage.com^$removeparam=sc
||startpage.com^$removeparam=t
||startpage.com^$removeparam=cat
||startpage.com^$removeparam=abp
||startpage.com^$removeparam=lui
||startpage.com^$removeparam=qloc
- Click Save Changes
- Open
https://startpage.com/do/settings?query=
- Change HTTP request method to
GET
- Click
Save your settings
Example | Example | Example |
---|---|---|
![]() |
![]() |
![]() |
Example | Example | Example | Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |