brave/brave-browser

[cr141 follow up] Fix GoogleSignInPermissionThrottle and AIChatBraveSearchThrottle prompts

Opened this issue · 0 comments

mkarolin commented

Upstream change https://source.chromium.org/chromium/chromium/src/+/3f13c486 is preventing the prompts from showing up.

AIChatBraveSearchThrottleBrowserTest.OpenAIChat_AskAnd* and GoogleSignInBrowserTest.* browser tests are failing.

Until we fix this, cr141 bump temporarily reverted the upstream change via a #define in the brave/chromium_src/components/permissions/permission_request_manager.cc override.

Test plan:

  1. Test that Google permission prompt is working correctly (by going for example to charthop.com and trying to login with Google)
  2. Test that AI Chat permission prompt is working correctly via steps in brave/brave-core#26082