brave/brave-browser

Enable password sync by default (for new users) on iOS

Closed this issue · 4 comments

StephenHeaps commented

Description

Password sync was enabled by default on desktop/android with #48915, but iOS currently uses a separate preference for this value (until #47487). We should update iOS to align with other platforms, respecting the feature flag.

ShivanKaul commented

brave-core version of this issue: #48915 (comment)

kjozwiak commented

The above requires 1.84.126 or higher for 1.84.x verification 👍

Uni-verse commented

Verified on iPhone 15 running iOS 18.6.2 using version 1.84.132

New Users

  • ensured that password sync is enabled by default for new users (brave-sync-default-passwords is enabled).
  • ensured that passwords are synced from other devices.
  • ensured that password sync is enabled when starting a standalone chain on iPhone.
example example example example example
Image Image Image Image Image

New Users - flag disabled

  • ensured that password sync is disabled by default for new users (brave-sync-default-passwords is disabled).
  • ensured that password sync is disabled when starting a standalone chain on iPhone.
example example example
Image Image Image

Existing Users - password syncing is disabled

  • ensured that password sync is not enabled when upgrading for existing users if initially not enabled for sync chain.
  • ensured that password syncing can be enabled post migration for existing users.
1.83.118 1.84.132
Image Image

Existing Users - password syncing is enabled

  • ensured that password sync is not disabled when upgrading for existing users if initially enabled for sync chain.

1.83.118 | 1.84.132

example example
Image Image
Uni-verse commented

Verified on iPad running iOS 18.5 using version 1.84.132

New Users

  • ensured that password sync is enabled by default for new users (brave-sync-default-passwords is enabled).
  • ensured that passwords are synced from other devices.
  • ensured that password sync is enabled when starting a standalone chain on iPad.
example example
Image Image

New users - flag disabled

  • ensured that password sync is disabled by default for new users (brave-sync-default-passwords is disabled).
  • ensured that password sync is disabled when starting a standalone chain on iPad.
example example
Image Image

Existing users - password syncing is disabled

  • ensured that password sync is not enabled when upgrading for existing users if initially not enabled for sync chain.
  • ensured that password syncing can be enabled post migration for existing users.

Existing users - password syncing is enabled

  • ensured that password sync is not disabled when upgrading for existing users if initially enabled for sync chain.