Add an option to enable Bookmarks as an option beside the URL bar

Question

Add an option to enable Bookmarks as an option beside the URL bar

Closed this issue 5 years ago · 20 comments

anthonypkeane commented 5 years ago

Description:

Add an option to allow users to turn on a button beside the top left URL for one click bookmarks

@jamesmudgett to provide a design, inc where to put the option in settings and the text.

Test Plan:

New bookmark toolbar icon should not be visible on an upgrade
New bookmark toolbar icon should not be visible on a fresh install for iPhone (default on for iPad)
There should be a new setting that enables this button to be visible.
- Changing this to on should make the button visible immediately
- On iPad, since the settings is in a form sheet, the button will appear on the toolbar, and should be visible (see screenshot in attached PR)
- On iPhone, button should be visible upon closing the settings
Turning the new setting off should have the opposite effect (making button disappear immediately)

Answer 1 · 2019-08-13T22:52:38.000Z

jamesmudgett commented 5 years ago

Answer 2 · 2019-08-13T22:54:37.000Z

Under General
Show Bookmarks Button

default = off

Answer 3 · 2019-08-13T23:31:01.000Z

Does this button automatically bookmark the current URL? Or does it open the bookmarks menu/screen?

Answer 4 · 2019-08-13T23:33:59.000Z

Opens the bookmark screen

Answer 5 · 2019-08-14T10:16:17.000Z

Add one more button in url bar with Rewards and see how little space there is

Answer 6 · 2019-08-27T16:12:05.000Z

@bradleyrichter can we get a new 2D icon for the bookmark button as the 3D one stands out too much in this design.

Answer 7 · 2019-08-27T20:49:20.000Z

anthonypkeane commented 5 years ago

Answer 8 · 2019-08-28T21:50:22.000Z

Archive.zip

Answer 9 · 2019-08-28T21:50:45.000Z

jamesmudgett commented 5 years ago

Answer 10 · 2019-08-29T00:16:59.000Z

Making this platform agnostic.

Answer 11 · 2019-08-29T02:47:14.000Z

Updating text to

Under General
Show Bookmarks Shortcut

default = off

Answer 12 · 2019-08-29T07:20:45.000Z

@anthonypkeane what about default off for iPhones, default on for iPads?
We have much more space on iPad's address bar

Answer 13 · 2019-08-29T11:10:27.000Z

The first screenshot, is the bookmark icon/button shown when url is in edit mode as well? #1391 (comment)

Answer 14 · 2019-08-29T15:47:39.000Z

I think the iPad should definately default to ”on” due to significantly more available space in the iPad address bar.

The iPhone: my device currently shows a ”Refresh” and ”Reading Mode” buttons between the address and the ”Shields” button. Сonstantly refreshing a page is not something a lot of people do on a constant basis, while opening bookmarks is. I would argue for the ”Refresh” button to go as tapping the address bar once followed by an ”Open” archieves the same result.

Answer 15 · 2019-08-29T18:42:20.000Z

I would suggest we get rid of the refresh button and replace it with bookmark button and bring back the pull-down refresh. One hand usage is def easy with pulldown refresh. This way we can solve the problem of spacing on iPhones

Answer 16 · 2019-08-29T19:03:06.000Z

@jhreis moving this into 1.12 as per earlier discussions 👍

[1] https://github.com/brave/brave-ios/milestone/24

Answer 17 · 2019-08-29T23:59:19.000Z

Confirming.

default = off for iPhone
default = on for iPad

@srirambv we'll come up with a more elegant solution soon. Pull to refresh is needed too, agree.

Answer 18 · 2019-09-02T16:42:57.000Z

@anthonypkeane @jhreis @srirambv are we worried about space? I guess this will be defaulted to off on iPhones so it's a users choice, but if a user ends up enabling both Rewards and Bookmarks, there won't be much space when it comes to the URL bar. We already have some users complaining about the URL space when they enable Rewards. Just a heads up 👍

Answer 19 · 2019-09-02T16:52:31.000Z

but if a user ends up enabling both Rewards and Bookmarks,

That was the idea behind suggesting this #1391 (comment), removing the reload button and bring back pull-down refresh

Screen size isn't as bad as Android since most of the iOS devices are pretty big except for iPhone SE and 6 which is small. Other devices should be fine with the bookmarks button and rewards in URL bar.

Answer 20 · 2019-09-06T22:22:37.000Z

Verification passed on iPhone XR with iOS 13.1 running 1.12(19.09.06.17)

Verified on a clean install of 1.12, bookmark button is not shown next to the URL bar
Verified on upgrade from Appstore build no bookmark button is shown next to the URL bar
Verified on upgrade, setting for show bookmark button is disabled
Verified enabling Show bookmark button adds a button next to the URL bar
Verified enabling bookmark button and removing the app from memory and relaunching retains the button and settings enabled
Verified disabling the setting removes the button immediately

Verification PASSED on iPad Air 3rd Generation using iOS 13.1 running 1.12 (19.09.13.06):

Verified that the bookmark button is enabled by default on clean installs
Verified that the bookmark button is enabled by default when updating from 1.11.4 (19.08.29.21)
Verified that disabling/enabling the bookmark button correctly removes the UI
Verified that disabled/enabled states are persisted when backgrounding Brave
Verified that disabled/enabled states are persisted when removing Brave from memory
Verified that bookmarks are not being lost when when going through the above

Verification passed on iPhone 7+ with iOS 12.4.1 running 1.12(19.09.13.06)

Verified on a clean install of 1.12, bookmark button is not shown next to the URL bar
Verified on upgrade from Appstore build no bookmark button is shown next to the URL bar
Verified on upgrade, setting for show bookmark button is disabled
Verified enabling Show bookmark button adds a button next to the URL bar
Verified enabling bookmark button and removing the app from memory and relaunching retains the button and settings enabled
Verified disabling the setting removes the button immediately