brave/brave-rewards-ios

Implement favicon fetching, caching, and database updates

Closed this issue · 1 comments

kylehickinson commented
  • Support favicon URLs which have been set to clear (kClearFavicon) during DB updates as seen here: brave-core/publisher_info_database.cc#L279
  • Implement fetchFavicon LedgerClient method which fetches a favicon based on the website URL (i.e. https://duckduckgo.com) and calls back with the favicon URL (i.e. https://duckduckgo.com/favicon.ico). This will be forwarded to brave-ios through brave-rewards-ios to find the favicon, download it, and cache it. (brave-core/rewards_service_impl.cc#L2002)
iccub commented

Temporary solution is to fetch favicons on clinet side(brave-ios) by publisher url, see for example here #115