brave/brave-talk

Review version bump for `ethers`

Closed this issue · 0 comments

Three weeks ago, when I looked at #954 -- now #993 )... the changes from ethers 6.3.0 to 6.4.1 seemed a bit larger than I was expecting. accordingly, I didn't approve the PR but decided to wait a few weeks to see if there was any community feedback.

In looking at https://github.com/ethers-io/ethers.js/issues (both open and closed) for the last three weeks. i see the usual level of issues/fixes being made. So, i'm thinking that I was a bit too cautious. Accordingly, after #1041 is approved and merged into production, my plan is to approve #993 (or its successor).

i am writing this as a separate issue, rather than making this a comment to #993 in case that PR is superseded before #1041 is approved.

So, fixed by #1041