brave/brave-talk

Not all available NFTs are shown to be selected as Avatars

Closed this issue · 7 comments

Description

Not all available NFTs are shown to be selected as Avatars

Steps to reproduce

  1. Have a bunch of NFTs in wallet
  2. Create a Web3 Talk room
  3. Only few selected NFTs are shown to be selected as Avatars

Actual result

image

Expected result

Provide all NFTs for user to select as Avatar

Additional info

cc: @mrose17 @nvonpentz

@srirambv - there is a filtering function. can you right-click on each of the responses you'll see the console, do "Copy object" on each, and DM the results to @hadiamjad and myself.

Screen Shot 2023-07-04 at 08 03 05

@hadiamjad - can you add a checkbox associated with the "Avatar NFT" box that indicates whether to "Show all NFTs". The default should be off. If the user turns it on, then show all the NFTs. (Hint: don't make another API call, we get all the NFTs when we make the all, so just return the (un)filtered list as appropriate!

Could you kindly send me the response objects? I observed a similar scenario during my testing, and it seemed to be caused by a high spam score.

Discussed it here. Indeed spam score being high is the cause of it. But irrespective of spam score we should show the NFTs so user can still choose to select which ever NFT they want.

I can see the checkbox for Show NFTs with Less Spam Score.

brave_WiFBDvi7yn.mp4

@hadiamjad maybe we should have it as Show NFTs with less Spam score instead of Show NFTs with Less Spam Score

@hadiamjad - I suggest the following:

  1. If all NFTs are below the spam score, then no checkbox, just the text "Showing all NFTs for your address". Otherwise,
  2. If the box is checked, the text should be "Show all NFTs".
  3. If the box is not checked, the text should be "Show all NFTs (not all being shown)".
  4. I would use the exact text and capitalization above. We can then show it to Matt to get the final edits!

Fixed and deployed!
image

Fixed by #1103