brave/brave-talk

Re-enable expiration of refresh token

mrose17 opened this issue · 4 comments

mrose17 commented

This was disabled for #81 ... since the issue hasn't re-appeared, we should probably re-enable the expiration.

mrose17 commented

development testing on #181

mrose17 commented

Testing steps:

  1. Create a room so you're the moderator.
  2. Go to the same room a while later and verify that you're still the moderator.
  3. Advance clock on computer past expiration date and see that the refresh token expires.

@tackley - is there a better set of testing steps?

  • 👍1
stephendonner commented

Testing steps:

1. Create a room so you're the moderator.

2. Go to the same room a while later and verify that you're still the moderator.

3. Advance clock on computer past expiration date and see that the refresh token expires.

@tackley - is there a better set of testing steps?

I've tried this to begin with, but hit an infinite loop on credential validation.

Slack thread here: https://bravesoftware.slack.com/archives/C021S0FN3V1/p1645587738539389

mrose17 commented

Fixed by #208

  • 👍1