brave/brave-talk

Cancel Sign request spits out JSON response instead of cancelled message

srirambv opened this issue · 4 comments

srirambv commented

Description

Cancel Sign request spits out JSON response instead of cancelled message

Steps

  1. Clean browser profile
  2. Create a new Brave Wallet
  3. Visit https://talk.brave.software and create a Web3 Talk room
  4. Click on Start 1:1 Web3 call button
  5. Cancel Sign request prompt
  6. JSON output is shown instead of cancelled message

Actual Result

image

Expected Result

Have a well formatted message instead of JSON response

mrose17 commented

@johnhalbert - in this case, the json needn't be displayed only user rejected action.

@mattmcalister - would you prefer other wording? if so, what?

mattmcalister commented

How about:

Unable to complete request. Please try again.

mrose17 commented

The message is generated because the user clicked "Cancel" instead of "Sign". So perhaps the better text would be "You cancelled the request."

or, if you prefer "How DARE you!"

srirambv commented

Looks fixed. Now shows Sing request cancelled instead of JSON response

Start Web3 Call Join Web3 Call
image image